Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for using multiple DID methods #70

Merged
merged 6 commits into from
Apr 20, 2024

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented Apr 4, 2024

Description of change

This change adds the functionality of using multiple different DID methods through one single Subject.

Links to any relevant issues

impierce/identity-wallet#94

How the change has been tested

Added the new MultiDidMethodSubject struct to tests/siopv2/implicit.rs and added #[rstest::rstest] to test_implicit_flow. This way test_implicit_flow is tested twice, once for did:key and once for did:test.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel force-pushed the feat/multi-did-methods branch 2 times, most recently from 6babdd9 to cc192b4 Compare April 4, 2024 20:38
@nanderstabel nanderstabel force-pushed the feat/multi-did-methods branch 2 times, most recently from 13f24f5 to 676793f Compare April 11, 2024 15:32
@nanderstabel nanderstabel changed the title Feat/multi did methods feat: add support for using multiple DID methods Apr 11, 2024
@nanderstabel nanderstabel self-assigned this Apr 11, 2024
@nanderstabel nanderstabel added Added A new feature that requires a minor release. Breaking change A change to the API that requires a major release. and removed Added A new feature that requires a minor release. labels Apr 11, 2024
@nanderstabel nanderstabel marked this pull request as ready for review April 11, 2024 15:39
Copy link

@daniel-mader daniel-mader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding support for a new feature while having a negative total amount of lines changed ... I like that! 😉

@nanderstabel nanderstabel merged commit a932af7 into dev Apr 20, 2024
1 check passed
@nanderstabel nanderstabel deleted the feat/multi-did-methods branch April 20, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants