Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump oid4vc-core dependency #9

Merged
merged 20 commits into from
Apr 23, 2024
Merged

chore: bump oid4vc-core dependency #9

merged 20 commits into from
Apr 23, 2024

Conversation

nanderstabel
Copy link
Contributor

@nanderstabel nanderstabel commented Apr 19, 2024 •
edited
Loading

Description of change

See title.

Blocked by:

Links to any relevant issues

How the change has been tested

Improved the can_deserialize_method test
The application of these code changes have been tested through UniCore in this PR as well: impierce/ssi-agent#44

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel changed the title chore: bumb oid4vc-core dependency, add verification_method chore: bumb oid4vc-core dependency, add verification_method to did:jwk producer Apr 19, 2024
@nanderstabel nanderstabel self-assigned this Apr 19, 2024
@nanderstabel nanderstabel added Breaking change A change to the API that requires a major release. Dependencies Issues related to an update of a dependency file labels Apr 19, 2024
@nanderstabel nanderstabel marked this pull request as ready for review April 19, 2024 13:07
@nanderstabel nanderstabel mentioned this pull request Apr 19, 2024
Merged
8 tasks
@nanderstabel nanderstabel changed the title chore: bumb oid4vc-core dependency, add verification_method to did:jwk producer chore: bump oid4vc-core dependency, add verification_method to did:jwk producer Apr 22, 2024
@nanderstabel nanderstabel changed the base branch from dev to refactor/error-handling April 22, 2024 08:09
@nanderstabel nanderstabel changed the title chore: bump oid4vc-core dependency, add verification_method to did:jwk producer chore: bump oid4vc-core dependency Apr 22, 2024
Base automatically changed from refactor/error-handling to dev April 22, 2024 11:59
daniel-mader
daniel-mader reviewed Apr 22, 2024
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
@nanderstabel nanderstabel merged commit 11ce737 into dev Apr 23, 2024
1 check passed
@nanderstabel nanderstabel deleted the chore/bump-oid4vc-core branch April 23, 2024 06:30
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-mader daniel-mader daniel-mader approved these changes

Assignees

@nanderstabel nanderstabel

Labels
Breaking change A change to the API that requires a major release. Dependencies Issues related to an update of a dependency file released on @beta
Projects
Impierce SSI Stack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanderstabel @daniel-mader