use new limit 0 functions [IMPLY-33067] #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbrewster
changed the title
vogievetsky
reviewed
Jun 12, 2023
mcbrewster
force-pushed
the
use_new_introspection
branch
from
932f50b
to
acfbbc3
Compare
remove introspec query
jgoz
force-pushed
the
use_new_introspection
branch
from
f821f2e
to
8b6bfd9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the introspection query used 1 row of results plus the result from the the explain plan to get the columns types for a druidSQL external. It now uses one query with a limit 0 with sqlTypesHeader and typesHeader enabled to get the types.