refactor: avoid Array.from the same thing twice

import-js · Jul 17, 2019 · e48eb0e · e48eb0e
1 parent 2443ba3
commit e48eb0e
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/rules/export.js b/src/rules/export.js
@@ -35,11 +35,8 @@ const tsTypePrefix = 'type:'
  * @returns {boolean}
  */
 function isTypescriptFunctionOverloads(nodes) {
-  return Array.from(nodes).some(node => node.parent.type === 'TSDeclareFunction') &&
-    Array.from(nodes).every(node => (
-      node.parent.type === 'TSDeclareFunction' ||
-      node.parent.type === 'FunctionDeclaration'
-    ))
+  const types = new Set(Array.from(nodes, node => node.parent.type))
+  return types.size === 2 && types.has('TSDeclareFunction') && types.has('FunctionDeclaration')
 }
 
 module.exports = {