Merge no-cjs, no-define from eslint-plugin-modules #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a rule to disallow mixed named and default exports in ES6.
|
Full approval granted ✅ at this point I may even just clsoe my project and point it here, great stuff! |
|
If you want to do that, let me know and I can pick up the other two rules as well. Only kept |
benmosher
added a commit
that referenced
this pull request
Dec 25, 2015
Merge no-cjs, no-define from eslint-plugin-modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xjamundx, want to get your sign off before merging this. Just want to make sure I properly credited you for these, and you're cool with how they're imported.
No worries if not, too.
(closes #79, #71, #115)