New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form): display Company field in donation form #2453
Comments
Nice Suggestion @mathetos Here I have try to create a small mock of what you are saying |
Interesting concepts @raftaar1191 - We still want to collect the person's name that's donating on behalf of the company. It would be difficult to shift how our data structure works to swap our name for company. |
First Name/Last Name followed by a Company field is an extremely common pattern on forms across the web, and I think that's the simplest approach here. Back-end
Front-end
|
If the customers requesting this feature want to see donations by company rather than individual, then that is something that should be handled via reports. We should not have to alter Give's data structure to accommodate it. In addition, having an individual to tie the donation back to is necessary for many reasons. If you receive a large donation from a company and it is pending, then you need to know who to contact. Many other reasons but you get the picture. |
@ravinderk Please see my updated task list above for implementation details, specifically whether you agree that this should be donor meta as I described. Reply here if you approve or have changes. @raftaar1191 Once Ravinder has approved, move forward with the tasks as defined. |
@kevinwhoffman List looks good to me. I have following question and suggestion.
|
Good question. Lets go with
I think you are right we should store the company as donation meta so that the company entered in the donation form is permanently recorded for that donation. But we should also record it in donor meta to associate the company with the individual so it can be displayed in the donor details screen. To summarize, the company in donation meta never changes, but the company in donor meta gets updated based on the most recent donation in which that donor supplied a company. I will update the tasks to reflect this approach. Thanks @ravinderk. |
Slack Call Summary Participants: @raftaar1191, @ravinderk |
remove code changes from pr impress-org#2926 which is not related to issue impress-org#2453
remove code changes from pr impress-org#2926 which is not related to issue impress-org#2453
remove code changes from pr impress-org#2926 which is not related to issue impress-org#2453
feat(donation): Add company name fields in donation form #2453
* release/2.1: (67 commits) fix(notice): update Give icon asset url fix(notice): move close icon svg to new directory style(code): improve code formatting fix(cache): search of prefix instead of complete string fix(cache): remove extra param from wp_delete_cache feat(admin-tools): change company name filed name #2946 feat(admin-tools): add company name filed value in donor meta #2946 feat(admin-tools): add company name filed in import donation import CSV #2946 feat(admin-email): Update email recipients description #2657 style(code): fix typo refactor(emails): code for pr #2942 feat(admin-email): add Email Recipients section to donor emails 2657 feat(admin-tools): Add Company Column in export donation history CSV #2453 design(admin-donation): refactor donor details UI #2453 design(admin-setting): move company name setting submenu tab to display menu #2453 refactor(admin-shortcode): improve fields and description for give_totals shortcode #1472 refactor(activation-banner): code review improvements refactor(activation-banner): code reformat using proper formatting fix(activation-banner): don't show banner for the add-on which is already dismissed. code(style): set max-height to show only three give add-on. ... # Conflicts: # includes/admin/tools/export/class-batch-export-payments.php # includes/misc-functions.php # templates/shortcode-receipt.php
User Story
As a donor, I want to associate my donation with my company so that it is clear that the contribution came from my organization rather than just myself.
Current Behavior
I currently cannot indicate that a donation is on behalf of my company because there is no field to do so.
Expected Behavior
I expect to see a
Company
field that is common across many web forms to indicate my company.Possible Solution
Allow a user to enable company donations in the
Form Display
settings. Doing so will add aCompany
field immediately after the name fields in the donation form. The company should be saved as donor meta and appear within the Donor details screen.Tasks
Company Donations
radio buttons setting withDisabled|Required|Optional
options where the Default option will be DisabledCompany Donations
radio buttons setting withDisabled|Required|Optional|Global
options. where the Default option will be GlobalDo you want a Company field to appear after First Name and Last Name?
Company
field appears on the front-end form if the setting is enabled. TheCompany
field should be a full-width field that appears belowFirst Name
andLast Name
. The name fields must always be present even if a company field is displayed, too.Company
field to payment meta as_give_donation_company
so it is permanently preserved.Company
field to donor meta as_give_donor_company
and update the donor meta if a company was previously entered for that donor.Company
field in Donor details screen if it is populated.The text was updated successfully, but these errors were encountered: