-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(donation): Add company name fields in donation form #2453 #2926
feat(donation): Add company name fields in donation form #2453 #2926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raftaar1191 Please use save
fn, for now, to save company name in donation meta as we discussed.
Remove unused helper function for company form field.
Use direct donor meta function to store meta data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raftaar1191 Please add the following issue.
- Autofill company name if any.
- Save company name if updates from profile editor ( not working currently)
- Read my all commit to this PR. I found lots of issues which I already fixed. Make sure you always create Pr with standard code.
…es-2453 Branch Update
…-2453 Branch Update
@ravinderk PR updates as you have suggested in the following comment. Kindly review it again and merge it |
remove code changes from pr impress-org#2926 which is not related to issue impress-org#2453
remove code changes from pr impress-org#2926 which is not related to issue impress-org#2453
remove code changes from pr impress-org#2926 which is not related to issue impress-org#2453
Review FindingsNice work on this feature. Please see the following 1. Move Global SettingsMove the settings from it's own subtab to the main "Display" tab: 2. Arrange Donation Fields Better3. Fix issue when clicking "Create a donor"When you click "create donor" all fields hide except this new field: 4. The "Donation History" export need to have the "Company" column |
@DevinWalker @mehul0810 and I discussed Donor detail metabox UI and this is the final mockup. |
Looks good @ravinderk 👍 |
This menu here is used to show the Donor Details not the Donation Details Does it sound good are we showing the Donation Company Name in Donor Details section and one more thing we can change the donor from the Dropdown as well this result in changing all the value like donor name donor email donor id but not the Donor Company Name Video Link: https://screencast-o-matic.com/watch/cFe31KDxwc |
…es-2453 Branch Update
@ravinderk @DevinWalker |
This PR is ready for review I have updated the Code as the comment made over to PR Comment |
@raftaar1191 good call on allowing |
@DevinWalker , The 'Company name' didn't update when I changed the donor. Is this bug? |
@nguyenrom thank you for reporting this. I created an issue for this. ref: #4483 |
Description
PR to fix #2453
How Has This Been Tested?
Company Donations
radio buttons setting withDisabled|Required|Optional
options where the Default option will be DisabledCompany Donations
radio buttons setting withDisabled|Required|Optional|Global
options. where the Default option will be GlobalDo you want a Company field to appear after First Name and Last Name?
Company
field appears on the front-end form if the setting is enabled. TheCompany
field should be a full-width field that appears belowFirst Name
andLast Name
. The name fields must always be present even if a company field is displayed, too.Company
field to payment meta as_give_donation_company
so it is permanently preserved.Company
field to donor meta as_give_donor_company
and update the donor meta if a company was previously entered for that donor.Company
field in Donor details screen if it is populated.Create New Donor
on donation detail screenVideo/Screenshots (jpeg or gifs if applicable):
Video Link: https://screencast-o-matic.com/watch/cFeqq9Dusj (deprecated)
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: