Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-conflict): WPML causes give_totals should output the correct donation total #3291

Closed
marutim opened this issue May 30, 2018 · 1 comment
Assignees

Comments

@marutim
Copy link

marutim commented May 30, 2018

User Story

As a user when I would use the give_totals shortcode, I accept it to show the correct total which should be the sum of all the donations for the donation forms included.

For example: If you have a donation form in English which is translated in French and have donated 11 USD in the form in English and 22 USD in the form in French.

Now if you use the give_totals shortcode and include the IDs of this two form.

In the page which is using the shortcode, It will display the total as 11 USD for English and 22 USD for French instead of 33USD.

Current Behavior

It should display the correct donation total.

Steps to Reproduce

I have created a doc which explains in details how to replicate this issue
https://docs.google.com/document/d/1-xeTxHn5K9yeYbRniV7T5BT6mYq_v3WG9BHehivBa8Y/edit

Related

Link to the HS ticket: https://secure.helpscout.net/conversation/574804454/17963?folderId=1457790

Environment

### WordPress Environment ###

Home URL: http://give-wpml.local
Site URL: http://give-wpml.local
WP Version: 4.9.6
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

Server Environment

Hosting Provider: DBH: localhost, SRV: give-wpml.local
TLS Connection: Warning: file_get_contents(): SSL operation failed with code 1. OpenSSL Error messages:
error:14090086:SSL routines:ssl3_get_server_certificate:certificate verify failed in /app/public/wp-content/plugins/give/includes/admin/tools/views/html-admin-page-system-info.php on line 188

Warning: file_get_contents(): Failed to enable crypto in /app/public/wp-content/plugins/give/includes/admin/tools/views/html-admin-page-system-info.php on line 188

Warning: file_get_contents(https://www.howsmyssl.com/a/check): failed to open stream: operation failed in /app/public/wp-content/plugins/give/includes/admin/tools/views/html-admin-page-system-info.php on line 188
TLS Connection:
Server Info: nginx/1.10.1
PHP Version: 7.1.7
PHP Post Max Size: 1,000 MB
PHP Time Limit: 1200
PHP Max Input Vars: 4000
PHP Max Upload Size: 300 MB
cURL Version: ❌ 7.38.0, OpenSSL/1.0.2l - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: 5.6.37
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.1.3
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Email access
Upgraded From: –
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://give-wpml.local/donation-confirmation/
Failure Page: http://give-wpml.local/donation-failed/
Donation History Page: http://give-wpml.local/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled

Session Configuration

Give Use Sessions: Enabled
Session: Disabled

Active Give Add-ons

Other Active Plugins

WPML Multilingual CMS: by OnTheGoSystems – 3.7.1

Inactive Plugins

Theme

Name: Twenty Seventeen
Version: 1.6
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

@raftaar1191
Copy link
Contributor

raftaar1191 commented May 31, 2018

@DevinWalker @mathetos
I need WPML plugin to test this issue which is a paid plugin

I have also asked in the development channel here is the slack link where we have discussed for the WPML addon https://givewp.slack.com/archives/C0FAGC83C/p1527744944000040

So I am moving this issue to blocker unless we have WPML plugin

ravinderk added a commit that referenced this issue Jun 1, 2018
fix(shortcode): give_totals should output the correct donation total #3291
@DevinWalker DevinWalker changed the title fix(shortcode): give_totals should output the correct donation total fix(plugin-conflict): WPML causes give_totals should output the correct donation total Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants