fix(shortcode): give_totals should output the correct donation total #3291 #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-3291 Branch Update
fix(donation): prevent donation amount from updating multiple times impress-org#3304
…e-3291 Branch Update
ravinderk
requested changes
Jun 1, 2018
includes/actions.php
Outdated
| */ | ||
| function give_remove_wpml_posts_where_filter() { | ||
| global $wpml_query_filter; | ||
| remove_filter( 'posts_where', array( $wpml_query_filter, 'posts_where_filter' ), 10, 2 ); |
There was a problem hiding this comment.
@raftaar1191 remove extra priority param
There was a problem hiding this comment.
Removed @ravinderk
includes/actions.php
Outdated
| */ | ||
| function give_add_wpml_posts_where_filter() { | ||
| global $wpml_query_filter; | ||
| add_filter( 'posts_where', array( $wpml_query_filter, 'posts_where_filter' ), 10, 2 ); |
There was a problem hiding this comment.
@raftaar1191 remove add filter
remove_filter( 'wpml_pre_parse_query', 'give_wpml_pre_parse_query', 10 );
remove_filter( 'wpml_post_parse_query', 'give_wpml_post_parse_query', 10 );
There was a problem hiding this comment.
Added @ravinderk
includes/actions.php
Outdated
| * | ||
| * @return WP_Query | ||
| */ | ||
| function give_wpml_post_parse_query( $q ) { |
There was a problem hiding this comment.
@raftaar1191 use __ add fn prefix because they are internal fn
There was a problem hiding this comment.
Added @ravinderk
includes/shortcodes.php
Outdated
| * | ||
| * @param array $atts shortcode attribute. | ||
| */ | ||
| do_action( 'give_totals_goal_shortcode_start', $atts ); |
There was a problem hiding this comment.
@raftaar1191 rename it to give_totals_goal_shortcode_before_render
There was a problem hiding this comment.
Changed @ravinderk
includes/shortcodes.php
Outdated
| * @param array $atts shortcode attribute. | ||
| * @param HTML $give_totals_output shortcode output. | ||
| */ | ||
| do_action( 'give_totals_goal_shortcode_end', $atts, $give_totals_output ); |
There was a problem hiding this comment.
@raftaar1191 rename it to give_totals_goal_shortcode_after_render
There was a problem hiding this comment.
Changed @ravinderk
|
@raftaar1191 can you check if these issue is related to your pr or not |
|
@ravinderk All the suggestions that are being suggested by you are being Done I try to regenerate the notices as well but I don't think this is related to to the current PR |
…e-3291 Branch Update
|
@raftaar1191 use |
|
@ravinderk PR updated as suggested by you but we need to add still add some filter because when we pass donation id in the Total Goal shortcode it is not working Please check the video to know about the issues and why I need to add that extra filter Video Link: https://screencast-o-matic.com/watch/cF1VIqbNow |
ravinderk
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to fix #3291
How Has This Been Tested?
Have tested by adding two donation form of the same type but the language is diff and runs on the same page with two diff language s
Screenshots (jpeg or gifs if applicable):
Video Link: https://screencast-o-matic.com/watch/cF1V1QbLWa
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: