New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compatibility with iThemes Sync #3989
Comments
Let me know if y'all have any questions. |
Research FindingsI dug into this a bit today and am finding it difficult to find a compatible solution with iThemes Sync without an extensive refactor of how we initialize our emails. The issue is that our plugin uses iThemes Sync Setting WP_ADMIN to
|
fix compatibility with iThemes Sync #3989
Feature Request
User Story
As a Give user who also depends on iThemes Sync for supporting my clients running Give, I want to be able to Sync my premium Give addons using Sync without problem.
Currently, Give's addons cannot be updated with Sync without a workaround.
The iThemes team gave us details on why this is happening, and it has to do with running our Email Notifications class action on
init
. If we instead usedadmin_init
it would be resolved. But that needs testing.Here's FULL details from iThemes Sync dev Lew Ayotte:
Possible Solution
My suggestion is to consider just upadting that action hook because it might be more efficient anyway since our Email Class doesn't need to run on the front-end at all (which
init
does) so we should be able to rely onadmin_init
reliably (hopefully).Acceptance Criteria
The text was updated successfully, but these errors were encountered: