Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility with iThemes Sync #3989 #4059

Merged
merged 3 commits into from
Mar 25, 2019
Merged

fix compatibility with iThemes Sync #3989 #4059

merged 3 commits into from
Mar 25, 2019

Conversation

ravinderk
Copy link
Collaborator

@ravinderk ravinderk commented Mar 25, 2019

Description

This pr will resolve #3989

How Has This Been Tested?

https://www.useloom.com/share/2dc94d18d73145a89fec80a18c3284a4

Note: I create issue branch from master which I have on my local because I saw that we need to resolve extra commit related issue in release/2.4.4 and master.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@DevinWalker
Copy link
Member

Review Findings

I've tested this PR in a live environment to verify iThemes Sync works as expected and it does:

2019-03-25_10-05-43

I then tested emails within Core and Recurring to verify no loss in functionality. We're good to go here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants