Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load stripe sdk only when stripe gateway is active #4237

Closed
11 of 13 tasks
mehul0810 opened this issue Aug 13, 2019 · 1 comment · Fixed by #4240
Closed
11 of 13 tasks

fix: load stripe sdk only when stripe gateway is active #4237

mehul0810 opened this issue Aug 13, 2019 · 1 comment · Fixed by #4240
Assignees

Comments

@mehul0810
Copy link
Contributor

mehul0810 commented Aug 13, 2019

Bug Report

User Story

As a user, I want to load the Stripe SDK only when Stripe gateway is active so that other plugin users can easily disable it.

Current Behavior

Currently, it is conflicting with "Membership Pro Ultimate WP" plugin.

Expected Behavior

I expect it to disable loading of Stripe SDK when gateway is inactive so that to avoid conflict with other plugins.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Install Give alongside Membership Pro Ultimate WP plugin
  2. Go to registration page of the membership plugin after configuring the plugin with Stripe.
  3. You will see error on the user registration page.

Visuals

image

Acceptance Criteria

  • Load Stripe SDK when Stripe gateway is active.
  • Resolve SDK loading fatal errors when Stripe gateway is not active for Stripe Free
  • Resolve SDK loading fatal errors when Stripe gateway is not active for Stripe Premium
  • Resolve SDK loading fatal errors when Stripe gateway is not active for Stripe + Recurring
  • Change loading pattern of files in recurring for better payment gateway support
  • Test the PR with Ultimate Membership WP Pro to ensure that the plugin functionality is not broken with Give loading Stripe SDK.
  • Test the PR with Authorize.NET by processing donations
  • Test the PR with Stripe by processing donations with all the supported payment methods
  • Test the PR with PayPal by processing donations
  • Test the PR with PayPal Pro by processing donations
@mehul0810 mehul0810 self-assigned this Aug 13, 2019
@mehul0810
Copy link
Contributor Author

mehul0810 commented Aug 13, 2019

Slack Call Summary

Participants: @mehul0810 @ravinderk
Topic: Discussion on the finding and the challenge I'm facing
Result: We have discussed the errors faced when disabling the loading of Stripe SDK which is due to the Stripe related files loaded in the admin. So, Ravinder suggested me to load the Stripe SDK and Stripe related files for front end only. Additionally, he suggested achieving this by de-coupling the functions and files for admin and frontend separately which will easily resolve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants