Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load stripe sdk only when stripe gateway is active #4237 #4240

Merged
merged 27 commits into from
Aug 27, 2019

Conversation

mehul0810
Copy link
Contributor

Description

This PR resolves #4237

How Has This Been Tested?

I've tested this PR as per the acceptance criteria on the issue description.

Types of changes

Bugfix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

Copy link
Collaborator

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehul0810 I suggest a few changes. Let me know if you have any question.

includes/gateways/stripe/class-give-stripe.php Outdated Show resolved Hide resolved
includes/gateways/stripe/class-give-stripe.php Outdated Show resolved Hide resolved
includes/gateways/stripe/class-give-stripe.php Outdated Show resolved Hide resolved
tests/unit-tests/tests-give.php Show resolved Hide resolved
Copy link
Collaborator

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@DevinWalker DevinWalker merged commit fd1dfc7 into release/2.5.5 Aug 27, 2019
@DevinWalker DevinWalker deleted the issue/4237 branch August 27, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: load stripe sdk only when stripe gateway is active
3 participants