Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured image displays in preview, but not when form inserted into a page #54

Closed
phillcoxon opened this issue Mar 18, 2015 · 3 comments

Comments

@phillcoxon
Copy link

When adding a new form it's possible to select a feature image.

When clicking on "Preview Form" it shows the featured image (or a placeholder image if no image is selected).

However, when adding the form to the page no featured image is shown.

This is confusing.

@ghost
Copy link

ghost commented Mar 19, 2015

The featured image acutally does show on the Form custom post type, but yes it does not show up as a shortcode.

Personally, I would remove the CPT options, keep it as just a shortcode option, and remove support for Featured image.

@DevinWalker
Copy link
Member

Some sites may have a lot of use for the single views. For instance, one of our clients has a donation site setup with many single views: https://citygospelmission.org/donate/hot-meals-donation/ https://citygospelmission.org/donate/job-readiness-donation/

The same functionality should be easy to implement in Give. We will most likely make an option under Settings > Display Options to enable or disable the single view, which will effectively disable the featured image as well.

@DevinWalker
Copy link
Member

Circling back to this one: So I've reviewed this and it's resolved because --

  • Disabling single views in now possible
  • Featured images should only display in single view and not within shortcode embeds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants