Improve Scrutinizer Score

[DevinWalker]

They provide a lot of great code improvement fixes that we should be completing ongoing as we can on Scrutinizer: https://scrutinizer-ci.com/g/WordImpress/Give/code-structure/master/hot-spots

[ramiy]

Interesting read about globals and how to remove them from your code: https://core.trac.wordpress.org/ticket/37699

[DevinWalker]

@ravinderk let me run this idea by you. We're getting hit pretty hard on Scrutinizer due to the code complexity "Conditions" and "Paths":

Link: https://scrutinizer-ci.com/g/WordImpress/Give/code-structure/master/operation/includes%2Fgateways%2Fpaypal-standard.php%3A%3Agive_process_paypal_payment

This example has >20000: https://scrutinizer-ci.com/g/WordImpress/Give/code-structure/master/operation/includes%2Fprocess-donation.php%3A%3Agive_purchase_form_validate_new_user

Proposed Solution

For the "Paths" it's likely due to checking if isset() in a ternary conditional. Why don't we create a function that we could pass all these conditonals through, or does one already exist in Core that I'm unaware of? We are mainly doing all these isset() and empty() conditionals to prevent PHP notices.

/**
 * Check variable.
 *
 * Helper function to check if a variable is set, empty, etc.
 *
 * @param        $variable
 * @param string $conditional
 * @param        $default
 *
 * @return mixed
 */
function give_check_variable( $variable, $conditional = 'isset', $default ) {

	if ( $conditional == 'isset' ) {
		$variable = isset( $variable ) ? $variable : $default;
	} elseif ( $conditional = 'empty' ) {
		$variable = empty( $variable ) ? $variable : $default;
	} elseif ( $conditional = 'null' ) {
		$variable = is_null( $variable ) ? $variable : $default;
	}

	return $variable;

}

[DevinWalker]

Closing this old issue out as it's an ongoing effort.