Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-populate First and Last name in PayPal Standard #945

Closed
mathetos opened this issue Aug 23, 2016 · 4 comments
Closed

Pre-populate First and Last name in PayPal Standard #945

mathetos opened this issue Aug 23, 2016 · 4 comments
Assignees
@DevinWalker
Milestone
1.6.1

Comments

@mathetos
Copy link
Member

PayPal has documentation on how to pre-populate fields in their payment form from your own payment form:
https://www.paypal.com/cgi-bin/webscr?cmd=_pdn_xclick_prepopulate_outside

Currently, we are passing the email address to PayPal Standard correctly, but not the first/last name. See here:

paypal-after-hitting-donate-fields-empty

Recommendation

  1. Make sure at minimum the First/Last names and emails are always populated correctly
  2. We have a snippet to ask the donor for address information as well. That should be updated to pass the information correctly as well. PayPal Billing fields not populating givewp-snippet-library#4
  3. We should consider adding a "Ask for Mailing/Billing Address" option to PayPal Standard as well.
@mathetos mathetos added the bug label Aug 23, 2016
@DevinWalker DevinWalker added this to the 1.6.1 milestone Aug 24, 2016
@DevinWalker DevinWalker self-assigned this Sep 6, 2016
DevinWalker pushed a commit that referenced this issue Sep 6, 2016
Add first_name and last_name to PP standard #945
a27bf33
DevinWalker pushed a commit that referenced this issue Sep 6, 2016
Change log added for #945
61e407c
@DevinWalker DevinWalker mentioned this issue Sep 6, 2016
Merged
DevinWalker pushed a commit that referenced this issue Sep 8, 2016
Merge branch 'master' into release/1.7
0ac7564 
* master: (24 commits)
  New POT file generated for 1.6.1
  Added change log for #863
  Added code to set default email receipt content upon install #863
  version bumped to 1.6.1
  Change log added for #945
  Add `first_name` and `last_name` to PP standard #945
  Fixed screenshot description issue #990
  Change log item added for #997
  php docs
  Fix issue #997
  Add extra class attribute
  Fixed @property-read conflicting with calls to read-only props and added missing props #675
  Addiction @property-read doc block #675
  Removed give_undo_donation_on_refund which is never used - left over from fork - code improved #675
  Add @property-read to class declaration to resolve https://scrutinizer-ci.com/g/WordImpress/Give/inspections/f8e0f43d-ff3d-4e85-9fbd-ac6be87fac72/issues/files/includes/emails/class-give-email-tags.php?status=new&orderField=path&order=asc&honorSelectedPaths=0 #675
  Simplify logic & Scrutinizer score #675
  meta doesn't exist in Give_Payment - it's payment_meta
  Use missing  parameter
  Fix the title level text in {donation} email template tag
  Fix issue #981
  ...

Fixed Conflicts:
	give.php
	includes/admin/reporting/export/class-batch-export-customers.php
	includes/gateways/paypal-standard.php
	includes/install.php
	includes/payments/class-give-payment.php
	languages/give.pot
	readme.txt
	templates/shortcode-profile-editor.php
@Benunc
Copy link
Member

Benunc commented Sep 12, 2016

do we send billing info (per the second Point in the original post's recommendation?) have a customer asking about that.

@DevinWalker
Copy link
Member

@Benunc if they add the fields to PayPal standard you mean?

@Benunc
Copy link
Member

Benunc commented Sep 12, 2016

correct. if they add billing info fields, are those passed on to PayPal?

@DevinWalker
Copy link
Member

DevinWalker commented Sep 12, 2016 •
edited
Loading

Yes they are, it looks like address1, address2, city, country, currently is passed but for some reason not state... I'll add that now.

DevinWalker pushed a commit that referenced this issue Sep 12, 2016
Pass state field to PayPal #945
0907fe1
DevinWalker pushed a commit that referenced this issue Sep 12, 2016
Merge branch 'master' into release/1.7
ea78536 
* master:
  Pass state field to PayPal #945
DevinWalker pushed a commit that referenced this issue Sep 12, 2016
Merge branch 'release/1.7' into issue/619
bafdb8c 
* release/1.7: (90 commits)
  Pass state field to PayPal #945
  Use `$current_user = wp_get_current_user()` instead of `global $current_user`
  Fixed incorrect semicolon
  Docs: add new and update old global documentation in phpDocs
  Docs: remove wrong/old global documentation from phpDocs
  i18n: escape translations strings
  i18n: make the error messages in trigger_error() function translatable
  Replace globals with dedicated functions when mapping deprecated filters/actions
  Use the action parameter instead of `global $wp_admin_bar`
  Remove global from the phpDocs
  Use `$current_user = wp_get_current_user()` instead of `global $current_user`
  Use `get_bloginfo( 'version' )` instead of `global $wp_version`
  Update function version from 1.8 to 1.7
  Remove edd references
  fix test
  New POT file generated for 1.6.1
  Added change log for #863
  Added code to set default email receipt content upon install #863
  version bumped to 1.6.1
  Tests: add two more tests
  ...

# Conflicts:
#	assets/scss/frontend/give-frontend.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
1.6.1
Development

No branches or pull requests
3 participants
@mathetos @DevinWalker @Benunc