-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Author" User role has a useless shortcode generator on pages and posts #845
Comments
I don't think the answer to this question is to prevent them from embedding the Give form (which by the looks of #849 is what it does). Instead, I think the generator should be made functional for them. Basically, there's no reason to limit who can embed Give forms from our end. The user can customize that however they want, but our roles/capabilities shouldn't be focused on adding forms to posts/pages. I know this is merged already, but I'm confused on it's actual utility. |
The problem is that currently the actual generator for the shortcode On Aug 8, 2016 6:29 PM, "Matt Cromwell" notifications@github.com wrote: I don't think the answer to this question is to prevent them from embedding Basically, there's no reason to limit who can embed Give forms from our I know this is merged already, but I'm confused on it's actual utility. — Reply to this email directly, view it on GitHub |
Ya, then my suggestion is to fix the generator rather than exclude the author. |
Here's the permissions Woo uses: https://github.com/woothemes/woocommerce-shortcodes/blob/master/includes/class-wc-shortcodes-admin.php#L24-L33 |
Current issue: if you create a User role of "Author," where the user has richediting enabled, Give is currently outputting a shortcode generator, but since they don't have the ability to see or edit give_forms, their shortcode generator is non-functional.
#842 addresses this
The text was updated successfully, but these errors were encountered: