Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-4.6 backwards compatibility which broke unit tests #957

Closed
DevinWalker opened this issue Aug 24, 2016 · 1 comment
Closed

Fix pre-4.6 backwards compatibility which broke unit tests #957

DevinWalker opened this issue Aug 24, 2016 · 1 comment
Assignees
@ramiy @DevinWalker @ravinderk
Milestone
1.7

Comments

@DevinWalker
Copy link
Member

DevinWalker commented Aug 24, 2016 •
edited
Loading

The usage of 4.6 only functions, specifically do_action_deprecated from #950, is now breaking compatibility with pre-4.6 versions of WordPress as well as our unit tests.

Option 1: We copy the function and wrap it in if(!function_exists('apply_filters_deprecated')) { //function here } until we're ready to bump our minimum to ver. 4.6

Option 2: We do similar to what we did with _give_deprecated_function https://github.com/WordImpress/Give/blob/master/includes/misc-functions.php#L515 and create a _give_deprecated_action which is essentially a copy of WP core's _deprecated_hook function.

I'm leaning on option 2 - @ravinderk let's discuss
@DevinWalker DevinWalker added this to the 1.7 milestone Aug 25, 2016
@DevinWalker DevinWalker changed the title Fix broken unit tests Fix pre-4.6 backwards compatibility which broke unit tests Aug 25, 2016
@ravinderk
Copy link
Collaborator

@DevinWalker I like second one.

@ravinderk ravinderk mentioned this issue Aug 25, 2016
Merged
DevinWalker pushed a commit that referenced this issue Aug 26, 2016
Update actions to use newly termed ones rather than now deprecated ones
9d4e0b3 
#957
DevinWalker pushed a commit that referenced this issue Aug 26, 2016
Update more action names #957
46081cd
@ravinderk ravinderk mentioned this issue Aug 29, 2016
Merged
DevinWalker pushed a commit that referenced this issue Aug 29, 2016
Merge branch 'release/1.7' into issue/619
c4ca573 
* release/1.7: (177 commits)
  Added change log for #964
  Make exception message translatable
  Update give_do_automatic_upgrades function
  Move upgades to 1.7
  Update function version from 1.6 to 1.7
  add missing `echo` after 9a2f35d
  Set gulp textdomain task autocorretion to true
  Update more action names #957
  Update actions to use newly termed ones rather than now deprecated ones #957
  Version bump for release/1.7 branch
  Change log added for #687
  Readme logs added for #896 and #773
  replace `edd` text-domain with `give`
  replace esc_attr_e() with esc_attr()
  add misisng text-domain
  gulp task
  Update doc block in formatting.php
  Refresh current month transient when payment update
  Add function to get stat transient key
  Update description in Give Settings Screen
  ...
DevinWalker pushed a commit that referenced this issue Aug 30, 2016
Better filter naming give_recount_customer_donation_statuses -> give_…
09cc8a7 
…recount_donors_donation_statuses and give_customer_recount_should_process_donation -> give_donor_recount_should_process_donation

#957 #896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramiy ramiy

@DevinWalker DevinWalker

@ravinderk ravinderk

Labels
None yet
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
3 participants
@ramiy @DevinWalker @ravinderk