Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only one text-domain #964

Closed
ramiy opened this issue Aug 26, 2016 · 5 comments
Closed

Use only one text-domain #964

ramiy opened this issue Aug 26, 2016 · 5 comments
Assignees
@ramiy
Milestone
1.7

Comments

@ramiy
Copy link
Contributor

ramiy commented Aug 26, 2016 •
edited

Seems like the plugin has 3 text-domains (give, cmb2, edd). We should unify all the text-domain to use only the "give" text-domain.

We can change them manually but the next time we update the cmb2 library (or any other external library) they will use the original text-domain.

We need a gulp task to do that automatically.
@ramiy
Copy link
Contributor Author

ramiy commented Aug 26, 2016

https://www.npmjs.com/package/gulp-checktextdomain

@ramiy ramiy mentioned this issue Aug 26, 2016
Merged
@DevinWalker
Copy link
Member

I agree, cmb2 does include a ton of their own translation files though: https://github.com/WordImpress/Give/tree/master/includes/libraries/cmb2/languages

I think we should phase out cmb2 like I've proposed here #668 - I also only see 4 strings using edd so that will be easy. A gulp task couldn't hurt for the future.

@ramiy
Copy link
Contributor Author

ramiy commented Aug 26, 2016

If you mentioned it, we should also delete the entire CMB2 languages directory.

@ramiy
Copy link
Contributor Author

ramiy commented Aug 27, 2016

Ok, now we can merge. I set the grunt task to "correct_domain: true"

@ramiy ramiy mentioned this issue Aug 27, 2016
Closed
@DevinWalker
Copy link
Member

Thanks!

@DevinWalker DevinWalker added this to the 1.7 milestone Aug 29, 2016
DevinWalker pushed a commit that referenced this issue Aug 29, 2016
Added change log for #964
e062b34
DevinWalker pushed a commit that referenced this issue Aug 29, 2016
Merge branch 'release/1.7' into issue/619
c4ca573 
* release/1.7: (177 commits)
  Added change log for #964
  Make exception message translatable
  Update give_do_automatic_upgrades function
  Move upgades to 1.7
  Update function version from 1.6 to 1.7
  add missing `echo` after 9a2f35d
  Set gulp textdomain task autocorretion to true
  Update more action names #957
  Update actions to use newly termed ones rather than now deprecated ones #957
  Version bump for release/1.7 branch
  Change log added for #687
  Readme logs added for #896 and #773
  replace `edd` text-domain with `give`
  replace esc_attr_e() with esc_attr()
  add misisng text-domain
  gulp task
  Update doc block in formatting.php
  Refresh current month transient when payment update
  Add function to get stat transient key
  Update description in Give Settings Screen
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramiy ramiy

Labels
None yet
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
2 participants
@ramiy @DevinWalker