-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only one text-domain #964
Comments
I agree, I think we should phase out |
If you mentioned it, we should also delete the entire CMB2 languages directory. |
Ok, now we can merge. I set the grunt task to "correct_domain: true" |
Thanks! |
* release/1.7: (177 commits) Added change log for #964 Make exception message translatable Update give_do_automatic_upgrades function Move upgades to 1.7 Update function version from 1.6 to 1.7 add missing `echo` after 9a2f35d Set gulp textdomain task autocorretion to true Update more action names #957 Update actions to use newly termed ones rather than now deprecated ones #957 Version bump for release/1.7 branch Change log added for #687 Readme logs added for #896 and #773 replace `edd` text-domain with `give` replace esc_attr_e() with esc_attr() add misisng text-domain gulp task Update doc block in formatting.php Refresh current month transient when payment update Add function to get stat transient key Update description in Give Settings Screen ...
Seems like the plugin has 3 text-domains (give, cmb2, edd). We should unify all the text-domain to use only the "give" text-domain.
We can change them manually but the next time we update the cmb2 library (or any other external library) they will use the original text-domain.
We need a gulp task to do that automatically.
The text was updated successfully, but these errors were encountered: