Issues/1190 #1202
Issues/1190 #1202
Conversation
|
@DevinWalker Please review this commit a17acc7. I changed SuggestionsI think logs are not static and we should provide a tool:
QuestionCurrently, user can fetch a list of donors for s specific form of all completed donations. What do you think? |
|
@ravinderk can you resolve the conflict here? |
|
@DevinWalker conflict resolved. |
|
@ravinderk thanks! |
| @@ -512,43 +512,19 @@ public function give_forms() { | |||
| return; | |||
| } | |||
|
|
|||
| global $give_logs; | |||
|
|
|||
| $args = array( | |||
There was a problem hiding this comment.
I see you're cleaning up the code here, which is nice. Have you tested this throughout the ensure it works as expected?
There was a problem hiding this comment.
@DevinWalker I did not find the use of this code inside core but it is working fine with give-cli.
| } | ||
|
|
||
| $sales = $give_logs->get_connected_logs( $args ); |
There was a problem hiding this comment.
Instead of counting logs you're counting the payments attached to each form?
Description
This pr will fix #1190
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: