Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/setup_transaction_id #1534

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

ravinderk
Copy link
Collaborator

Description

if ( empty( $transaction_id ) || (int) $transaction_id === (int) $this->ID ) {
 	$gateway        = $this->gateway;
 	$transaction_id = apply_filters( "give_get_payment_transaction_id-{$gateway}", $this->ID );
}

In above condition I think (int) $transaction_id === (int) $this->ID comparision is required to set default trasaction id. This PR will remove this extra check from if condition.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ravinderk ravinderk changed the title Fix if condition in setup_transaction_id Hotfix/setup_transaction_id Feb 22, 2017
@DevinWalker DevinWalker merged commit 3b33239 into impress-org:release/1.8.3 Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants