-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues/1617 #1622
Issues/1617 #1622
Conversation
@DevinWalker Few point from this PR:
Question: There are still lot of transients we are using in our code, they are around |
*/ | ||
$cached_options = $wpdb->get_col( | ||
$wpdb->prepare( | ||
"SELECT * FROM {$wpdb->options} where (option_name LIKE '%%%s%%' OR option_name LIKE '%%%s%%')", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this also check if the transient is expired?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DevinWalker I designed different model on how cached value store in DB with a timestamp and I am removing all cache without checking expiration to upgrade every cache value.
For Ref: https://github.com/WordImpress/Give/pull/1622/files/f9af10b7a180d8e7e79dad82c5d4882a29ddf30b#diff-338475964ff644868092ed67b2a5cb0eR149
@ravinderk yes, please update all transients to use the new class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update all transient usage throughout Give core to use new caching class. :)
Description
This Pr will fix #1617
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist: