Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-2553 Fix success message on profile edit and logout on password… #2759

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

Sidsector9
Copy link
Contributor

Related #2553

Description

  • Change of first_name, last_name, display_name or email will output a success message as:
    Your profile has been updated.
  • Changing only the password will output a success message as:
    Your password has been updated
  • Change of both of the above will display a success message as:
    Your profile and password has been updated.
  • Change of password will logout and redirect to the current page with a success message corresponding
    to the type of change.

How Has This Been Tested?

This has only been tested manually by first updating profile, then only updating password, and then updating everything all at once.

Types of changes

Previously, on successfully updating the profile, the page redirected to:
http://give.local/profile-editor-shortcode/?updated=true

Now the page redirects with an additional query string parameter:
http://give.local/profile-editor-shortcode/?updated=true&update_code={number}

Where {number} takes values:
0: No change
1: Profile change only
2: Profile and password change
3: Password change only

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@DevinWalker
Copy link
Member

First PR! 👍

@ravinderk ravinderk self-requested a review February 5, 2018 10:02
@ravinderk ravinderk merged commit 52a1810 into impress-org:release/2.0.3 Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants