WIP: fix(form): ensure state field styles don't break when changing country #3255 #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(form): do not unformat the min/max amount using JS functions.
fix(admin-form): prevent js notice when edit price type setting field impress-org#3161
fix(admin-setting): prevent setting menu to appear on top of modal impress-org#3164
* release/2.1.1: fix(admin-shortcode): clarify Donation Form Grid shortcode generator fix(db-upgrade): do not show upgrade notice on WP update page fix(donation): update default donation amount fix(donation): update form max value fix(donation): improve if condition
* release/2.1.2: doc(release): Add change log for 2.1.1 and run npm prod for new POT file
fix(compat): prevent missing donation data with Restrict Content Pro impress-org#2710
# Conflicts: # includes/admin/donors/donor-actions.php # includes/admin/payments/view-payment-details.php # includes/misc-functions.php
refactor(form): code cleanup for impress-org#3011 impress-org#3248
fix(admin-tool): export and Import of Donations must be in sync without errors impress-org#2135
raftaar1191
changed the title
|
@ravinderk I have sent the PR as we have discussed over the call. Kindly have a look at this PR and let me know if there is any thing |
|
Closing this PR and sending new one #3287 as discuss over slack with @ravinderk Slack Chat Link: https://givewp.slack.com/archives/C0FAGC83C/p1527673556000504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to fix #3255
How Has This Been Tested?
Tested by changing the doantion coutry fields also by changing the gateway and then chaging the country fields again
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: