Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Markdown parser #811

Closed
thawk opened this issue Jun 15, 2022 · 2 comments
Closed

Upgrade Markdown parser #811

thawk opened this issue Jun 15, 2022 · 2 comments

Comments

@thawk
Copy link
Contributor

thawk commented Jun 15, 2022

It seems that extras/markdown/markdown.js is a quite old version. In that file, the last updated date is marked as 2013-09-15T16:12Z.
Suggest to upgrade it to a more modern version, or replace by another parser.
I've tried using marked, it's as easy as replacing one line in plugins/extras/extras.js.
@henrikingo
Copy link
Member

+1
I'd welcome a PR for sure.

thawk added a commit to thawk/impress.js that referenced this issue Jun 26, 2022
@thawk
Improve markdown support.
ea5f5aa 
1. Support `marked`, you can using it instead. impress#811
2. Auto detect slide title (using first non-blank line). impress#816
3. Auto trim the indentation, so it can be indent like regular HTML.
   impress#812
@thawk thawk mentioned this issue Jun 26, 2022
Merged
thawk added a commit to thawk/impress.js that referenced this issue Jun 26, 2022
@thawk
Improve markdown support.
6e0b372 
1. Support `marked`, you can using it instead. impress#811
2. Auto detect slide title (using first non-blank line). impress#816
3. Auto trim the indentation, so it can be indent like regular HTML.
   impress#812
thawk added a commit to thawk/impress.js that referenced this issue Jun 27, 2022
@thawk
Improve markdown support.
fcc340e 
1. Support `marked`, you can using it instead. impress#811
2. Auto detect slide title (using first non-blank line). impress#816
3. Auto trim the indentation, so it can be indent like regular HTML.
   impress#812
thawk added a commit to thawk/impress.js that referenced this issue Aug 15, 2022
@thawk
Improve markdown support.
cd5ce77 
1. Support `marked`, you can using it instead. impress#811
2. Auto trim the indentation, so it can be indent like regular HTML.
   impress#812
henrikingo pushed a commit that referenced this issue Aug 19, 2022
@thawk
Improve markdown support. (#817)
f8dd0e9 
1. Support `marked`, you can using it instead. #811
2. Auto trim the indentation, so it can be indent like regular HTML.
   #812
@thawk
Copy link
Contributor Author

thawk commented Aug 23, 2022

Closed by #817

@thawk thawk closed this as completed Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thawk @henrikingo