Allow non root resources

[mangas]

#453

Changes

Added option allowNonRootResources
Added a function WrappedGrpcServer that encapsulates the logic of getting the gRPC endpoint from http.Request

Verification

Added Unit-Tests that ensure the same behavior for the canonical case
Tested with flag on by default

[johanbrandhorst]

A few things, but generally this looks okay. I'd like approval from another maintainer as well as this is an API change.

[mangas]

Is it worth running one of the suites with the non default option to make sure that there is always something that tests the option?

[johanbrandhorst]

Is it worth running one of the suites with the non default option to make sure that there is always something that tests the option?

I'd rather add a new test which exercises the option, but if it's complicated it's not necessary. it's a pretty straightforward change.

[johanbrandhorst]

LGTM but I'd like a look from @jonny-improbable as well if possible before agreeing to merge this API change.

[mangas]

@johanbrandhorst @jonnyreeves I believe the failed tests are unrelated but let me know if there is anything I'm missing here

[johanbrandhorst]

Restarted it

[mangas]

Will we be able to get some more 👀 on this PR? 🙏

[johanbrandhorst]

🤞 lets hope tests pass

[johanbrandhorst]

🔁

[mangas]

🔁

[johanbrandhorst]

🙄 ♻️

[johanbrandhorst]

Thanks for your contribution!

[mangas]

Thank you for the help 👍