This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
Fixed retry handling for endpoint watcher. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/resolvers/k8s/streamer.go
Outdated
| select { | ||
| case <-firstUpdateCh: | ||
| case <-time.After(100 * time.Millisecond): | ||
| case <-time.After(300 * time.Millisecond): |
There was a problem hiding this comment.
If this change is necessary, this should probably be a flag.
Signed-off-by: Bartek Plotka <bartek@improbable.io>
bwplotka
force-pushed
the
watcher-fix
branch
from
d936f8f
to
f4cd935
Compare
|
PTAL @stefan-improbable |
stefan-improbable
approved these changes
Nov 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartek Plotka bartek@improbable.io