This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
Make the address on which metrics are served by adding a flag `server… #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_metrics_address`.
bwplotka
suggested changes
Dec 8, 2017
cmd/kedge/main.go
Outdated
| flagHttpTlsPort = sharedflags.Set.Int("server_http_tls_port", 8443, "TCP port to listen on for HTTPS. If gRPC call will hit it will bounce to gRPC handler. If 0, no TLS will be open.") | ||
| flagHttpPort = sharedflags.Set.Int("server_http_port", 8080, "TCP port to listen on for HTTP1.1/REST calls for debug endpoints like metrics, flagz page or optional pprof (insecure, but private only IP are allowed). If 0, no insecure HTTP will be open.") | ||
| flagBindAddr = sharedflags.Set.String("server_bind_address", "0.0.0.0", "address to bind the server to") | ||
| flagMetricsAddress = sharedflags.Set.String("server_metrics_address", "/debug/metrics", "address on which to serve metrics") |
There was a problem hiding this comment.
Could you change "address" to "URL" in both variable and flag name?
There was a problem hiding this comment.
I think path should be the correct name here
bwplotka
reviewed
Dec 11, 2017
cmd/kedge/main.go
Outdated
| flagHttpTlsPort = sharedflags.Set.Int("server_http_tls_port", 8443, "TCP port to listen on for HTTPS. If gRPC call will hit it will bounce to gRPC handler. If 0, no TLS will be open.") | ||
| flagHttpPort = sharedflags.Set.Int("server_http_port", 8080, "TCP port to listen on for HTTP1.1/REST calls for debug endpoints like metrics, flagz page or optional pprof (insecure, but private only IP are allowed). If 0, no insecure HTTP will be open.") | ||
| flagBindAddr = sharedflags.Set.String("server_bind_address", "0.0.0.0", "address to bind the server to") | ||
| flagMetricsAddress = sharedflags.Set.String("server_metrics_path", "/debug/metrics", "path on which to serve metrics") |
There was a problem hiding this comment.
Same with var name (: s/flagMetricsAddress/flagMetricsPath
bwplotka
approved these changes
Dec 11, 2017
|
Oops accidentally closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_metrics_address`.