Don't use reserved words as function names in generated service

[jonbretman]

• Function names in the generated service code are run through normaliseFieldObjectName to avoid invalid syntax
• Test added to check this behaviour
• Make sure all tests run and fix some import path errors in test/service/grpcweb.ts

[jonnyreeves]

Thanks for raising 😀

delete is but one of many reserved keywords in JavaScript. We already have a utility which normalises field names in utils.ts (normaliseFieldObjectName) - please could you modify your patch to handle all of these keywords in a generic fashion and add some test coverage to ensure we don't regress on this change in the future?

Thanks

[jonbretman]

@jonnyreeves so it looks like #56 actually stopped the tests from running 😢You can see in the Travis build that 0 test ran - https://travis-ci.org/improbable-eng/ts-protoc-gen/builds/361377789?utm_source=github_status&utm_medium=notification

> mocha --require source-map-support/register ./build/src
  0 passing (3ms)

My guess is it's this line.

I've add a look at trying to fix them but getting a failing test - #62

[jonbretman]

@jonnyreeves ok all fixed now - using the normaliseFieldObjectName util function. Also only some of the tests were running so fixed that.

[jonnyreeves]

Could you please add a test to ensure methods are appropriately prefixed?

[jonnyreeves]

Morning @jonahbron, the example protos have been moved by the change landed in #55, you will need to rebase your changes. Also, as requested, please can you add a test-case so we don't accidentally regress on this feature in the future?

Thanks :)

[jonbretman]

@jonnyreeves rebased and added a test to check the name of the generated function.

Also all 91 tests are now running on this branch instead of just the 70 on master. This is because the test glob was not including the test/service/grpcweb.ts file.

[jonnyreeves]

Thanks @jonbretman; I'll look to roll out a new release of ts-protoc-gen at some point this week; hopefully we can also get the fix for #67 in as well.