Updated readme #14
Updated readme #14
Conversation
|
@Aju100 Please provide a clear description of PR. And also mention issue number "Fixes issue #number" |
|
@imskr sure thank you for your kind feedback. |
There was a problem hiding this comment.
Looks good to me, work upon the issue description as per @imskr said.
Do make the changes asap.
|
@Ishaan28malik thank you so much |
|
Please explain the issue and don't send PR directly from your master. @Aju100 |
|
@Aju100 Do we really need those ignored files? Can you explain |
|
@imskr sure we need those ignored files. Like there will be some files and data like secret API key , node_modules, python virtual environment folder and many more which shouldn't be public . It should be kept privately. that's why we need ignored files. |
|
@imskr can you please reivew this PR |
|
@Aju100 You have added many things in .gitignore. ATM, we aren't using such private details such as API key. |
|
sure u can close this pr. |
sorry for the things which i haven't followed from the instructors. I have create Issue #28 and you can review for it.