Fix attribute query handling for extension schemas #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing serialization code supports including and excluding attributes as required by RFC 7644 but does not handle "fully qualified" attributes that contain the URN prefix, i.e. "urn:ietf:params:scim:schemas:extension:enterprise:2.0:User:employeeNumber" because it expects that `.` is used as a separator instead of `:`. This commit adds detection of `:` and updates the existing unit tests to capture this scenario. Under RFC 7644, clients are expected to request attributes from extension schemas in this form [0]. It clarifies that the "attribute" query parameter should be composed of > ... a comma-separated list of resource attribute names in standard > attribute notation Where the distinct "standard attribute notation" for extension attributes is further detailed as follows [1]: > Clients MAY omit core schema attribute URN prefixes but SHOULD fully > qualify extended attributes with the associated schema extension URN > to avoid naming conflicts. For example, the attribute 'age' defined in > "urn:ietf:params:scim:schemas:exampleCo:2.0:hr" is uniquely identified > as "urn:ietf:params:scim:schemas:exampleCo:2.0:hr:age". [0]: https://datatracker.ietf.org/doc/html/rfc7644#section-3.9 [1]: https://datatracker.ietf.org/doc/html/rfc7644#section-3.10 Signed-off-by: Aaron Jacobs <aaron.jacobs@rstudio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing serialization code supports including and excluding attributes as required by RFC 7644 but does not handle "fully qualified" attributes that contain the URN prefix, i.e.
urn:ietf:params:scim:schemas:extension:enterprise:2.0:User:employeeNumberbecause it expects that.is used as a separator instead of:.This PR adds detection of
:and updates the existing unit tests to capture this scenario.Under RFC 7644, clients are expected to request attributes from extension schemas in this form. It clarifies that the "attribute" query parameter should be composed of
Where the distinct "standard attribute notation" for extension attributes is further detailed as follows: