Support overrideing icons with the default format #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Battstat has a default format that it prints if the user does not provide one. However, it is broken if the user provides an override for the charging or discharging icons. This patch fixes this and supports the default format with icon overrides.
|
CC @imwally |
|
I suppose this project is dead now :( |
|
It's not dead yet! Thanks for the PR. I responded in issue #7 and would love to hear more about the issue. I think we might be able to come up with another solution but I'd love to hear more about what is causing the issue. Thanks again! |
|
Merged! Sorry for the long delay. Thanks again for your contribution! |
|
Thanks for the merge! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Battstat has a default format that it prints if the user does not provide one. However, it is broken if the user provides an override for the charging or discharging icons.
This patch fixes this and supports the default format with icon overrides (fixes #7).
Example of the new support (note - the preexec and postexec messages are a separate tool I use):
