Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsse: transfer the dsse part into a new repo #122

Merged

Conversation

shibumi
Copy link
Collaborator

@shibumi shibumi commented Sep 10, 2021

Please fill in the fields below to submit a pull request. The more
information that is provided, the better.

Fixes issue: #110

Description of pull request:

This PR removes the pkg/ssl library from the in-toto-golang repository and uses our new secure-systems-lib/dsse
library. Furthermore, now that we use the package name dsse we should probably rename a few functions. To name a few:

  • NewSSLSigner() -> NewDSSESigner()
  • The SSLSigner struct -> DSSESigner
  • TestSSLSigner() -> TestDSSESigner()

Please verify and check that the pull request fulfills the following
requirements
:

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@shibumi shibumi changed the title dsse: transfer the dsse part into a new repo WIP: dsse: transfer the dsse part into a new repo Sep 10, 2021
@shibumi shibumi changed the title WIP: dsse: transfer the dsse part into a new repo dsse: transfer the dsse part into a new repo Sep 10, 2021
@shibumi shibumi marked this pull request as draft September 10, 2021 22:47
@adityasaky
Copy link
Member

adityasaky commented Sep 11, 2021

Thanks for picking this up, @shibumi! Let me cut v0.1.0 of go-sslib though.

Here we go: https://github.com/secure-systems-lab/go-securesystemslib/releases/tag/v0.1.0

@adityasaky adityasaky self-requested a review September 11, 2021 00:28
@adityasaky
Copy link
Member

cc @dlorenc for sigstore's dependence on this code.

@shibumi
Copy link
Collaborator Author

shibumi commented Sep 11, 2021

Thanks for picking this up, @shibumi! Let me cut v0.1.0 of go-sslib though.

Here we go: https://github.com/secure-systems-lab/go-securesystemslib/releases/tag/v0.1.0

cutting a new release for it is a good idea. Makes it easier to pinpoint it. Good idea!

We should also start adding Maintainers.md files etc in the go-securesystemslib repository.

in_toto/model.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@shibumi shibumi force-pushed the shibumi/migrate-dsse-to-a-new-repo branch 2 times, most recently from 7ea010d to 9efc906 Compare October 17, 2021 19:06
@shibumi shibumi changed the title dsse: transfer the dsse part into a new repo WIP: dsse: transfer the dsse part into a new repo Oct 17, 2021
@shibumi shibumi marked this pull request as draft October 17, 2021 19:16
@shibumi shibumi changed the title WIP: dsse: transfer the dsse part into a new repo dsse: transfer the dsse part into a new repo Oct 17, 2021
@shibumi shibumi force-pushed the shibumi/migrate-dsse-to-a-new-repo branch from 9efc906 to 5656758 Compare October 17, 2021 19:39
@shibumi shibumi marked this pull request as ready for review October 17, 2021 19:39
@adityasaky adityasaky merged commit 7bdfdb1 into in-toto:master Oct 17, 2021
@shibumi shibumi deleted the shibumi/migrate-dsse-to-a-new-repo branch October 17, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants