Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch DSSE provider to go-securesystemslib #111

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

adityasaky
Copy link
Contributor

Summary

Switches from using github.com/in-toto/in-toto-golang/pkg/ssl to github.com/secure-systems-lab/go-securesystemslib/dsse.

Ticket Link

N/A.

Release Note

Uses new provider for DSSE.

Signed-off-by: Aditya Sirish <aditya@saky.in>
@lukehinds
Copy link
Member

Thanks @adityasaky could you give a little more context, for example this is more optimised code, the ssl modules will be deprecated and are these at parity around features. Just need to understand any possible impacts.

@adityasaky
Copy link
Contributor Author

Whoops, meant to include a link: in-toto/in-toto-golang#122.

The code at github.com/secure-systems-lab/go-securesystemslib/dsse is exactly the same as the prototype that is currently in in-toto-golang. It was originally written with in-toto in mind, given ITE-5 (https://github.com/in-toto/ITE/blob/master/ITE/5/README.adoc), but we decided it made sense for it to live independently for use in other projects (see: in-toto/in-toto-golang#110).

Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adityasaky , will override CI as its not related to this change (its' the aws plugin code).

@lukehinds lukehinds merged commit 866281b into sigstore:main Sep 30, 2021
@adityasaky adityasaky deleted the switch-dsse-provider branch September 30, 2021 11:46
mtrmac pushed a commit to mtrmac/sigstore that referenced this pull request Mar 10, 2023
Based on: sigstore/cosign#40 (comment)

Signed-off-by: Luke Hinds <lhinds@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants