Drop Python 3.5, add Python 3.9 and update requirements #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.5 has now reached its end-of-life and has been retired. https://www.python.org/dev/peps/pep-0478/ The optional (but highly recommended) 'cryptography' dependency has also just dropped support for 3.5. Continuing support for 3.5 does not seem worth the effort. Instead we signal support for the new stable Python 3.9 via the corresponding classifier. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
- Disable dropped Python 3.5 builds from tox, Travis and Appveyor - Enable 3.9 builds for tox and Travis Note, 3.9 doesn't seem to work on Appveyor out of the box, instead of troubleshooting, we should just switch to GitHub Actions soon (see in-toto#407). - Add 3.8 to Appveyor Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Adopt docs for updating requirements-pinned.txt from based on their revision in tuf and sslib: - theupdateframework/python-tuf#982 - secure-systems-lab/securesystemslib#209 The update includes a transfer of the doc header + script/commands from requirements-pinned.txt to requirements.txt, and a thus resulting simplification of the commands. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
With in-toto#402 in-toto adopted a backwards-incompatible change in securesystemslib. Since then, in-toto requires securesystemslib>=0.18.0. This reflects that requirement in setup.py and requirements.txt. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
requirements-pinned.txt lists all immediate and transitive dependencies combined for all supported Python versions. Given both the recent change in Python version support (-3.5, +3.9) and an update of requirements.txt (sslib>=0.18.0), this commit semi-automatically updates the pinned dependencies according to the instructions in requirements.txt's doc header: Updated dependencies are: - Remove dropped transitive dependency colorama - Bump cryptography to 3.3.1 Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
lukpueh
force-pushed
the
update-py-versions-and-deps
branch
from
511d5fe
to
f238f8b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #: None
Description of the changes being introduced by the pull request:
Drop Python 3.5
Python 3.5 has now reached its end-of-life and has been retired https://www.python.org/dev/peps/pep-0478/. The optional (but highly recommended) 'cryptography' dependency has also just dropped support for 3.5. Continuing support for 3.5 does not seem worth the effort.
Add Python 3.9
Add setup.py classifier and configure tox and travis to build for 3.9 (Appveyor would require some troubleshooting which we omit in favor of Consider switching to GitHub Actions for automated testing #407)
Update requirements
Please verify and check that the pull request fulfills the following
requirements: