Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v17: Correction of backport deviation #189

Closed
julianhofmann opened this issue Jul 17, 2023 · 1 comment
Closed

v17: Correction of backport deviation #189

julianhofmann opened this issue Jul 17, 2023 · 1 comment
Assignees
@julianhofmann

Comments

@julianhofmann
Copy link
Contributor

While backporting #178 for v17 in fe54de2, changes of QueueRepository::findAllByNewsletterAndDispatchedStatus( have gotten lost.

(Thanks to Dave, who discovered this!)
julianhofmann added a commit that referenced this issue Jul 17, 2023
@julianhofmann
[BUGFIX] Correction of backport deviation
95b8360 
While backporting #178 for v17 in fe54de2, changes of QueueRepository::findAllByNewsletterAndDispatchedStatus( have gotten lost.

Fixes: #189
@julianhofmann julianhofmann self-assigned this Jul 17, 2023
julianhofmann added a commit that referenced this issue Jul 18, 2023
@julianhofmann
[BUGFIX] Correction of backport deviation (model Newsletter)
05108c1 
While backporting #178 for v17 in fe54de2, changes of model Newsletter have gotten lost.

Fixes: #189
julianhofmann added a commit that referenced this issue Jul 18, 2023
@julianhofmann
[BUGFIX] Remove spread operator
2e34529 
While backporting #178 for v17 in fe54de2, spread operators have been moved into v17. But spread operator is not compatible with supported PHP 7.2-7.3

Related: #189
@einpraegsam
Copy link
Collaborator

This is already in branch 17 and available via 17.6.3 - can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianhofmann julianhofmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@einpraegsam @julianhofmann