[FEATURE] Adds Event before sending out testmail #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This event can be used to deactivate the internal sending of test emails and implement your own logic, e.g. sending test newsletters via a separate queue. Relates to: https://projekte.in2code.de/issues/61246
This event is executed before the body text for the individual newsletter is processed. The event can be used to change or reset the body text that is used for parsing. Relates to: https://projekte.in2code.de/issues/61356
dhoffmann1979
force-pushed
the
feature/add-testmail-send-event
branch
from
7f9665f
to
e6d663a
Compare
julianhofmann
requested changes
Jan 26, 2024
| ]); | ||
| if ($user !== null) { |
There was a problem hiding this comment.
So, without $user the variable logs would be not set/exist in Fluid. Currently, Fluid is tolerating undefined variables. As far as I know, this should be changed soon.
Passing an (empty) array - as before - would be cleaner.
The whole block of assignments is useless with $user===null... Why the distinction/decision that only one variable is not assigned?
| declare(strict_types=1); | ||
| namespace Vendor\Extension\EventListener; | ||
|
|
||
| use In2code\Luxletter\Events\AfterTestMailButtonClickedEvent; |
There was a problem hiding this comment.
Import AfterTestMailButtonClickedEvent is not used in this snippet.
|
Thx, I just pushed a new commit based on this PR. Some small changes are implemented in b16c18f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first event can be used to deactivate the internal sending of test emails and implement your own logic, e.g. sending test newsletters via a separate queue.
Relates to: https://projekte.in2code.de/issues/61246
The second event is executed before the body text for the individual newsletter is processed. The event can be used to change or reset the body text that is used for parsing.
Relates to: https://projekte.in2code.de/issues/61356