Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NetInfo dependency #343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pkcwong
Copy link

@pkcwong pkcwong commented Jun 21, 2019

Fix for #342

Changed NetInfo dependency from react-native to @react-native-community as suggested in React Native docs.

https://facebook.github.io/react-native/docs/netinfo.html

@ghost
Copy link

ghost commented Jul 12, 2019

Please merge this PR.
Facing NetInfo issue on RN 0.60

@pkcwong
Copy link
Author

pkcwong commented Jul 12, 2019

Same issue goes for AsyncStorage as well, I think a few other packages too

@jakeols
Copy link

jakeols commented Jul 17, 2019

Anything else that can be done for this? Getting the error undefined is not an object (evaluating '_reactNative.NetInfo.isConnected') relating to this.

@pkcwong
Copy link
Author

pkcwong commented Jul 17, 2019

My workaround now is to clone this entire repo, then add the directory as an Npm dependency.
Here is an example.
https://github.com/pkcwong/react-native-meteor-starter/tree/master/libs/react-native-meteor
Note I cloned this repo into a /libs directory in my project. Then in my package.json I do this.

"react-native-meteor": "file:./libs/react-native-meteor"

https://github.com/pkcwong/react-native-meteor-starter/blob/master/package.json#L13

You can then fix the dependencies yourself.

@ma-lemire
Copy link

Plz merge this fix !

@pkcwong
Copy link
Author

pkcwong commented Aug 1, 2019

@ma-lemire Last commit to this repo is nearly a year ago. You can use this workaround for now.
#343 (comment)

@ma-lemire
Copy link

@pkcwong Thx man works well ! i just add async-storage with @react-native-community/async-storage

@JonahGroendal
Copy link

@charpeni could you merge this pls?

@JonahGroendal
Copy link

downgrading react-native to 0.59.10 works as an alternative to #343 (comment)

@wallind
Copy link

wallind commented Jan 16, 2020

My team ran into this issue and was able to fix it using the commit in this PR. This is a definitive issue with using React Native versions 0.60.0 and above.

@charpeni please merge this PR into the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants