Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is too much duplication of code in notes and actions #2426

Closed
timlinux opened this issue Oct 1, 2015 · 2 comments
Closed

There is too much duplication of code in notes and actions #2426

timlinux opened this issue Oct 1, 2015 · 2 comments
Assignees
@Gustry
Labels
Coding standards
Milestone
Version 3.5

Comments

@timlinux
Copy link
Contributor

timlinux commented Oct 1, 2015 •
edited
Loading

Whilst reviewing all the IF's for #2409, I found that the actions and notes contain a lot of duplicate code.

Please look at moving the terms to definitions.py or similar and generally moving duplicated notes items into a central place then just importing them into each module that needs them.
@timlinux timlinux added this to the Version 3.3 milestone Oct 1, 2015
@Gustry Gustry modified the milestones: Version 3.5, Version 3.3 May 13, 2016
@Gustry Gustry assigned Gustry and unassigned timlinux May 13, 2016
@Gustry
Copy link
Contributor

Gustry commented May 13, 2016

Just to link the issue : #2765

@timlinux
Copy link
Contributor Author

timlinux commented Jul 4, 2016

Closing - we will address this in #2987

@timlinux timlinux closed this as completed Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gustry Gustry

Labels
Coding standards
Projects
None yet
Milestone
Version 3.5
Development

No branches or pull requests
3 participants
@timlinux @lucernae @Gustry