Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need to make dock work with the new ImpactFunction class #3320

Closed
timlinux opened this issue Oct 18, 2016 · 2 comments
Closed

We need to make dock work with the new ImpactFunction class #3320

timlinux opened this issue Oct 18, 2016 · 2 comments
Assignees
@timlinux
Labels
Impact function
Milestone
Version 4.0 alpha

Comments

@timlinux
Copy link
Contributor

No description provided.

@timlinux timlinux added this to the Version 4.0 beta milestone Oct 18, 2016
@timlinux timlinux self-assigned this Oct 18, 2016
timlinux added a commit to timlinux/inasafe that referenced this issue Oct 18, 2016
@timlinux
In progress implementation to make dock work with new impact function…
1df7647 
… class. See inasafe#3320
timlinux added a commit to timlinux/inasafe that referenced this issue Oct 18, 2016
@timlinux
In progress implementation to make dock work with new impact function…
85665a0 
… class. See inasafe#3320
timlinux added a commit that referenced this issue Oct 19, 2016
@timlinux
In progress implementation to make dock work with new impact function…
e779fa4 
… class. See #3320 (#3321)
@timlinux timlinux mentioned this issue Oct 29, 2016
Merged
timlinux added a commit to timlinux/inasafe that referenced this issue Oct 29, 2016
@timlinux
Deleted old aggregator class for inasafe#3320 and InaSAFE v4 refactoring
0a04287
timlinux added a commit to timlinux/inasafe that referenced this issue Oct 30, 2016
@timlinux
Fix for failing test in inasafe#3320
7bf2576
timlinux added a commit that referenced this issue Oct 30, 2016
@timlinux
Refactor dock to not use IF's (#3368)
8260a8f 
* In progress implementation to make dock work with new impact function class. See #3320

* Updates towards removing references to impact functions to dock and its tests.

* Show a nicer informative message in the dock if we get a InvalidKeywordsForProcessingAlgorithm exception

* Fix missing apostrophe

* Fixes for failing tests

* Fixes for failing tests

* Deleted old aggregator class for #3320 and InaSAFE v4 refactoring

* Fix failing test following removal of impact function in dock

* Updated dock based on comments from @Charlotte-Morgan in #3368

* Further implementation for #3220. Added new definitions for processing steps. Added gui progress callback which shows analysis step details and profiling data. Updated definitions report to show analysis steps (still need to fix sort order). Lots of other small tweaks to dock to support running IF from dock.

* Fix for progress bar not showing

* PEP8

* Fix for failing test in #3320
@Gustry
Copy link
Contributor

Gustry commented Feb 6, 2017

What is this ticket @timlinux ?

@timlinux
Copy link
Contributor Author

timlinux commented Feb 6, 2017

I think we can just close it. Thanks!

@timlinux timlinux closed this as completed Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timlinux timlinux

Labels
Impact function
Projects
None yet
Milestone
Version 4.0 alpha
Development

No branches or pull requests
2 participants
@timlinux @Gustry