Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to stay current with iOS app #21

Closed
axenuli opened this issue Nov 7, 2014 · 6 comments
Closed

Updating to stay current with iOS app #21

axenuli opened this issue Nov 7, 2014 · 6 comments

Comments

@axenuli
Copy link
Contributor

axenuli commented Nov 7, 2014

Hey,

In a separate email Scott mentioned that there is some work to do to get the Android app up to date with changes in the iOS app. Opening this issue to start the conversation as I'd be happy to help! Will work on a version for Minnesota Master Naturalists at some point.

Thanks!

@axenuli
Copy link
Contributor Author

axenuli commented Nov 11, 2014

After getting the app built and comparing to the iOS version (and other social media apps), I see that the primary task is to update the Android app so that it has the same elements as other social media apps, i.e., not a ListView, but instead the bar that lets the user choose which view to load. I can do that. Please let me know if there are additional guidelines or if someone is already on the task. Thanks!

@axenuli
Copy link
Contributor Author

axenuli commented Nov 19, 2014

I've started replacing ActionBarSherlock with AppCompat, prior to updating with icons/action buttons. Will look at new Toolbar in Android 5.0 after that (migration will be easier after putting in AppCompat v7).

@kueda
Copy link
Member

kueda commented Nov 21, 2014

Cool, glad you've got it building. Let's try and break the work into more
granular issues, though. Is there a reason you want to replace Sherlock
with appcompat? @budowski, any experience with the latter?

On Tuesday, November 18, 2014, axenuli notifications@github.com wrote:

I've started replacing ActionBarSherlock with AppCompat, prior to updating
with icons/action buttons. Will look at new Toolbar in Android 5.0 after
that (migration will be easier after putting in AppCompat v7).


Reply to this email directly or view it on GitHub
#21 (comment)
.

@axenuli
Copy link
Contributor Author

axenuli commented Nov 22, 2014

Sherlock will no longer be updated, since Google released appcompat. So... as part of putting in action buttons (or tabs) to replace the MenuActivity, seems like a good time to replace sherlock with appcompat. (Android 5 seems to be taking it even further with Toolbar.)
I agree about breaking the work into granular issues. sherlock->appcompat would just be step 1 of moving from the MenuActivity to ActionBar/ToolBar buttons. Or?

@axenuli
Copy link
Contributor Author

axenuli commented Dec 16, 2014

@kueda Let me know if I can help with any tasks. I can't tell if anyone else is working on them, or what your priorities are, but I'd be happy to help. Sounds like this one is more than you had in mind so feel free to close and let me know what you need!

@kueda
Copy link
Member

kueda commented Dec 16, 2014

Sorry, bad project management on our part. I actually just added one that might be good for you: #24. Want to give that a try? If so, let's talk about it over there.

@kueda kueda closed this as completed Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants