-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation es-MX #20
Conversation
Hey Carlos, these mostly look good, but you need to resolve some issues before I will merge. calonsot@f2554ad#L0L291 calonsot@c6ae568#L0L291 |
Yeah, the first (calonsot/inaturalist@f2554ad#L0L291) was just a test that's not suppose to be change thanks, Carlos Alonso. ----- Mensaje original ----- De: "Ken-ichi" notifications@github.com Hey Carlos, these mostly look good, but you need to resolve some issues before I will merge. |
You can remove the commits if you want: http://stackoverflow.com/questions/448919/how-can-i-remove-a-commit-on-github But it's also fine just to fix the problems in new commits. For the unmerged conflicts, you need to choose which one you want to keep and which to discard. Since you've already committed them, you'll need to delete the <<<<< and ==== stuff and choose the side that should remain. The both look pretty similar, so it might just be a change in whitespace. In the future if you have conflicts when you merge, you should resolve the conflicts with |
thanks Ken-ichi! Carlos Alonso. ----- Mensaje original ----- De: "Ken-ichi" notifications@github.com You can remove the commits if you want: http://stackoverflow.com/questions/448919/how-can-i-remove-a-commit-on-github |
Hey Carlos, these changes were all handled by #22, right? Can I close this? |
Also did some minor edits to integrate into our schema, e.g. ditched references to the legacy column, all the other columns added by NatureWatchNZ. Coordinate system stuff on observation form_fields still needs to be integrated, since that was particularly messy. WR#209898 - Bulk upload Conflicts: app/controllers/observations_controller.rb app/helpers/observations_helper.rb app/models/observation.rb app/models/observation_field.rb app/models/project.rb app/models/project_observation.rb app/models/taxon.rb app/views/observations/_form_fields.html.erb app/views/observations/_new_nav.html.erb app/views/observations/import.html.erb app/views/projects/show.html.erb config/config.yml.example config/locales/en.yml spec/models/observation_spec.rb
only this commit: f5be603