Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev setup changes #3466

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Dev setup changes #3466

merged 4 commits into from
Jun 23, 2022

Conversation

kueda
Copy link
Member

@kueda kueda commented Jun 16, 2022

  • Site.default creates a new site if one doesn't exist
  • welcome/index should function without a site
  • System calls in bin/setup raise exceptions
  • Hardcoded default postgres username and password in example database and
    Docker config
  • Minor updates to some data loading scripts

@kueda
Some changes to the way we set up a new dev env
0337d23 
* Made Site.default create a new site if one doesn't exist
* Made welcome/index function without a site
* Made system calls in bin/setup raise exceptions
* Hardcoded default postgres username and password in example database and
  Docker config
@kueda
Updates to place loading scripts
5faa569
@kueda
Let's see if this magically satisfies CI...
47168f1
@kueda
Use password if set when exporting site data w/ psql
20d7c7d 
Probably not the best approach, but I haven't found a way to set up PostgreSQL
in Docker or Github CI that doesn't require a password.
@kueda kueda requested a review from pleary June 16, 2022 23:51
pleary
pleary approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@pleary pleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me

@kueda kueda merged commit bbb2463 into main Jun 23, 2022
@kueda kueda deleted the dev-setup-changes branch June 23, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleary pleary pleary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kueda @pleary