Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awesome! ffmpeg_all_codec.js failing when audio in video #16

Open
Noitidart opened this issue Jun 24, 2016 · 12 comments
Open

Awesome! ffmpeg_all_codec.js failing when audio in video #16

Noitidart opened this issue Jun 24, 2016 · 12 comments

Comments

@Noitidart
Copy link

Hi there!
This is really cool. I didn't realize ffmpeg was in use by another firefox addon. I made an addon last week which records the screen. WebRTC records as .webm but stuff like Twitter only accepts gif or mp4. Things are working great EXCEPT when I have audio in the webm recording. If there is audio, then converting it to mp4 fails. I was wondering if you could please take a look at these topics - bgrins/videoconverter.js#49

Here is my addon repository - https://github.com/Noitidart/Screencastify/

Here is my released addon: mozilla/addons#145 (comment)

I couldn't solve this conversion to mp4, if you could help that would be awesome. I set up a demo here:
http://noitforks.github.io/videoconverter.js/demo/

You can run any command on this page. But if you click "Video to mp4" you will see the error I am getting.

@Noitidart Noitidart changed the title Awesome! ffmpeg_all_codec.js Awesome! ffmpeg_all_codec.js failing when audio in video Jun 24, 2016
@inbasic
Copy link
Owner

inbasic commented Jun 25, 2016

@Noitidart the FFmpeg used in videoconverter.js is outdated. For webm conversions you need a newer version of FFmpeg. Try the executable and it works just fine; https://github.com/inbasic/media-converter/blob/master/src/lib/config.js#L3

P.S: videoconverter.js is not performing very well on Firefox. Why don't you use the FFmpeg executable instead?

@Noitidart
Copy link
Author

Aw drats, thanks for that. Is it possible to pack with my addon a cross platform executable? I know exe works for Windows, but what about for mac and linux?

@inbasic
Copy link
Owner

inbasic commented Jun 25, 2016

I don't recommend packing ffmpeg. You can ask users to install FFmpeg or even you can offer downloading it like I did in this extension.

or alternatively, you can push a pull request to Media Converter to support MP4 conversion and then use this extension in background for your conversion requests; https://github.com/inbasic/media-converter/blob/master/connect.md

but what about for mac and linux

See the JSON response of the feed URL. FFmpeg executable is available on all these three platforms.

@Noitidart
Copy link
Author

Noitidart commented Jun 25, 2016

Thanks so much! I try to make my addons have 0 dependencies, so I rather not have them install. May you please point me to the cross platform executables?
Seriously appreciate this!

@Noitidart
Copy link
Author

Noitidart commented Jun 25, 2016

Holy heck I think I found them, they are like 40mb each and for linux they dont have one solution the have one for Fedora, Ubuntu, Debian, etc etc. Shoot. I think Ill try to push ffmpeg.js guys to update :(

@inbasic
Copy link
Owner

inbasic commented Jun 25, 2016

yes, there is not a single cross platform executable. You need to offer platform dependent executables; see browser_download_url's of https://api.github.com/repos/inbasic/ffmpeg/releases/latest

think Ill try to push ffmpeg.js guys to update

Have you tried to convert an actual video file using the ffmpeg.js? Firefox literally cannot handle it (Chrome is much better though).

@Noitidart
Copy link
Author

Yep it works first class. I do it off main thread from a ChromeWorker. Only
issue is converting webm with audio to mp4. It even updates a message box
on all progress as it converts its pretty sweet!

On Sat, Jun 25, 2016 at 4:09 AM, InBasic notifications@github.com wrote:

yes, there is not a single cross platform executable. You need to offer
platform dependent executables; see browser_download_url's of
https://api.github.com/repos/inbasic/ffmpeg/releases/latest

think Ill try to push ffmpeg.js guys to update

Have you tried to convert an actual video file using the ffmpeg.js?
Firefox literally cannot handle it (Chrome is much better though).


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGE8iYG_k0PmQSBOAGtX7pR95FdBxyvPks5qPQxugaJpZM4I9nqP
.

@Noitidart
Copy link
Author

Screencast using my addon to show you ffmpeg in firefox woohoo :d https://www.youtube.com/watch?v=gCTFPmDmHwE

@inbasic
Copy link
Owner

inbasic commented Jun 25, 2016

Nice! Thanks for sharing

@Noitidart
Copy link
Author

@inbasic by chance do you know of any alternative js libraries to convert webm files?

@inbasic
Copy link
Owner

inbasic commented Jul 6, 2016

Not that I am aware of. You can also try to compile the webm part of ffmpeg using https://github.com/kripken/emscripten

@Noitidart
Copy link
Author

Oh interesting, thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants