-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
55 bug column habitat is missing from griis checklist #57
Merged
SanderDevisscher
merged 23 commits into
uat
from
55-bug-column-habitat-is-missing-from-griis-checklist
Dec 20, 2023
Merged
55 bug column habitat is missing from griis checklist #57
SanderDevisscher
merged 23 commits into
uat
from
55-bug-column-habitat-is-missing-from-griis-checklist
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll rework the flow with @damianooldoni suggestions #55 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #55 by reworking how I retrieve the GRIIS checlist.
Prior to this PR I would just download the GRIIS checklist from gbif using
aspbo/src/download_griis_checklist.R
Lines 13 to 14 in 7af04bb
This however seemed to be missing info about habitat, degree of establisment, pathways, etc... so I had to link this data from a dwca downloaded manually from gbif.
I've also changed the workflow trigger to test whether something has been pushed to
data/input/GRIIS/**
on theuat
branch.when changes occur concerning the GRIIS checklist the resp. dwca should be download as "./data/input/GRIIS/dwca-unified-checklist.zip" into
data/input/GRIIS/
thus triggering a update.