Fix pandas on <2.0 #364
Merged
Fix pandas on <2.0 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niche Vlaanderen is not yet compatible with pandas 2.
cecileherr
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Thanks for the changes, I am indeed still working with pandas 1.5.3 here.
Since I had merged my changes to the documentation into the master, there was a minor conflict in installation.rst, so I solved it manually in 4aa5356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Niche Vlaanderen is not yet compatible with pandas 2.
This caused the tests to fail (and would also fail for users).
This PR adjust the requirements file and documentation to make sure the correct version is installed.