Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 0.3.2 #440

Merged
merged 16 commits into from
Feb 1, 2024
Merged

version 0.3.2 #440

merged 16 commits into from
Feb 1, 2024

Conversation

mvarewyck
Copy link
Collaborator

No description provided.

@mvarewyck mvarewyck changed the title 432 hotfix 426 and 439 hotfix Nov 27, 2023
@mvarewyck mvarewyck mentioned this pull request Nov 27, 2023
2 tasks
Copy link
Collaborator

@SanderDevisscher SanderDevisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#426 seems to not be fixed by this PR. When I select verwilderde kat and switch the source (select the only source HVV_wilder) the app still times out.
When looking at the docker logs I see this:

Warning: Error in mapply: zero-length inputs cannot be mixed with those of non-zero length
2023-11-27 15:31:18   70: mapply
2023-11-27 15:31:18   69: Map
2023-11-27 15:31:18   67: <reactive>
2023-11-27 15:31:18   51: results$textPopup
2023-11-27 15:31:18   45: <observer>
2023-11-27 15:31:18    2: runApp
2023-11-27 15:31:18    1: reportingGrofwild::runWildApp

#439 seems to be fixed on all levels and parts of the app

@SanderDevisscher SanderDevisscher marked this pull request as draft January 11, 2024 09:50
@mvarewyck mvarewyck changed the title 426 and 439 hotfix version 0.3.2 Jan 12, 2024
@mvarewyck mvarewyck added this to the v0.3.2 milestone Jan 12, 2024
@mvarewyck mvarewyck marked this pull request as ready for review January 12, 2024 11:03
Copy link
Collaborator

@SanderDevisscher SanderDevisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#426 is seems fixed now but when testing the fix for #426 I got a time out when I deleted the species to select a new one.

In docker I get this printout:

Warning: Error in if: missing value where TRUE/FALSE needed
  69: createSpaceData
  68: <reactive>
  52: results$summarySpaceData
  45: <observer>
   2: runApp
   1: reportingGrofwild::runWildApp
Warning: Error in if: missing value where TRUE/FALSE needed
  77: <Anonymous>
Warning: Error in if: missing value where TRUE/FALSE needed
  100: <Anonymous>
Warning: Error in if: missing value where TRUE/FALSE needed
  75: <Anonymous>
Warning: Error in if: missing value where TRUE/FALSE needed
  54: <Anonymous>

Copy link
Collaborator

@SanderDevisscher SanderDevisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#442 seems to be fixed but when I select 1 dashboard indicator all other indicators get enabled as well

@SanderDevisscher
Copy link
Collaborator

SanderDevisscher commented Jan 12, 2024

eea675b implemented a fix when a similar issue occurred previously but it seems to no longer do the trick.

@SanderDevisscher SanderDevisscher marked this pull request as draft January 12, 2024 13:41
@SanderDevisscher
Copy link
Collaborator

SanderDevisscher commented Jan 12, 2024

selecting any province, faunabeheerzone or gemeente enables all indicators as well.

Copy link
Collaborator

@SanderDevisscher SanderDevisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues still occur with the dashboard:

When selecting only waarnemingen for huidige verspreiding everzwijn I get the following error:

image

it is independent of year.
Selecting only afschot yields the same view. While selecting both yields the expected view.
Selecting neither results in a timeout. The timeout occurs also in PRD, the other issues not.

@mvarewyck
Copy link
Collaborator Author

Note: Commit a8f6407 requires the wildschade data to be created again (column dataSource replaces indieningType).
I've replaced the data on S3 bucket "inbo-wbe-uat-data" (applied required changes to current data on S3 and uploaded to S3 again).

@SanderDevisscher
Copy link
Collaborator

ok for review ?

@mvarewyck
Copy link
Collaborator Author

ok for review ?

@SanderDevisscher yes docker runs fine locally

Copy link
Collaborator

@SanderDevisscher SanderDevisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all issues appear to be fixed

@SanderDevisscher SanderDevisscher merged commit 0d25a18 into master Feb 1, 2024
@SanderDevisscher SanderDevisscher deleted the 432_hotfix branch February 1, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants