Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AUTH #197

Merged
merged 2 commits into from
Apr 10, 2021
Merged

Add support for AUTH #197

merged 2 commits into from
Apr 10, 2021

Conversation

makarchuk
Copy link
Contributor

Resolves: #62
Added support for LOGIN and PLAIN auth methods. Any credentials are accepted.

@makarchuk makarchuk force-pushed the auth-plain branch 2 times, most recently from 9263832 to 3997acb Compare April 10, 2021 12:33
jhillyerd
jhillyerd requested changes Apr 10, 2021
View reviewed changes
Copy link
Collaborator

@jhillyerd jhillyerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small change

pkg/server/smtp/handler.go Outdated Show resolved Hide resolved
@jhillyerd
Copy link
Collaborator

Looks great, thank you!

@jhillyerd jhillyerd merged commit 261bbef into inbucket:master Apr 10, 2021
@cardonator cardonator mentioned this pull request May 3, 2021
Closed
@jhillyerd
Copy link
Collaborator

Note that I accidently merged this to the wrong branch, have rolled it back from master, but it will go out in the next release candidate, which I am working on this week.

jhillyerd added a commit that referenced this pull request Jul 31, 2021
@jhillyerd
Merge tag 'v3.0.0-rc2' into develop
1465e6f 
Added:

- Support for SMTP AUTH (#197, thanks makarchuk)
- Dark mode support (#218, thanks nerones)

Fixed:

- Prevent potential click jacking (#190, thanks stuartskelton)
- Error on 8 character long SMTP commands (#221)
- Allow empty username and password during AUTH (#225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhillyerd jhillyerd Awaiting requested review from jhillyerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inbucket support AUTH LOGIN ?
2 participants
@makarchuk @jhillyerd