Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predict annotations directly instead of using PredictedSpan #1194

Closed
jcklie opened this issue May 21, 2019 · 0 comments
Closed

Predict annotations directly instead of using PredictedSpan #1194

jcklie opened this issue May 21, 2019 · 0 comments
Assignees
@jcklie
Labels
Module: Recommender ⚙️ Refactoring
Milestone
0.10.0

Comments

@jcklie
Copy link
Contributor

jcklie commented May 21, 2019

Is your feature request related to a problem? Please describe.
It would be nice if recommenders could directly predict annotations instead of using PredictedSpan. This would unify internal and external recommender, allow prediction of whole annotations instead of single features and more.

Describe the solution you'd like

  • Add score feature automagically to layer features
  • Refactor recommenders to predict annotation directly
@jcklie jcklie added this to the 0.10.0 milestone May 21, 2019
@jcklie jcklie self-assigned this May 21, 2019
jcklie added a commit that referenced this issue May 24, 2019
@jcklie
#1194 - Predict annotations directly instead of using PredictedSpan
239d3ce 
- Refactor predictions naming
jcklie added a commit that referenced this issue May 24, 2019
@jcklie
#1194 - Predict annotations directly instead of using PredictedSpan
83b6540 
- Add score features
jcklie added a commit that referenced this issue May 24, 2019
@jcklie
#1194 - Predict annotations directly instead of using PredictedSpan
16c900d 
- Remote predicted span
- Start to fix tests
jcklie added a commit that referenced this issue May 24, 2019
@jcklie
#1194 - Predict annotations directly instead of using PredictedSpan
e6892dd 
- Fix tests
jcklie added a commit that referenced this issue May 24, 2019
@jcklie
#1194 - Predict annotations directly instead of using PredictedSpan
e922861 
- Fix dependencies
jcklie added a commit that referenced this issue May 24, 2019
@jcklie
#1194 - Predict annotations directly instead of using PredictedSpan
a80ca9e 
- Fix EL test
jcklie added a commit that referenced this issue May 27, 2019
@jcklie
#1194 - Predict annotations directly instead of using PredictedSpan
bae052c 
- Add test for monkey patching
jcklie added a commit that referenced this issue May 27, 2019
@jcklie
#1194 - Predict annotations directly instead of using PredictedSpan
e99b1fc 
- Write some documentation
jcklie added a commit that referenced this issue Jun 3, 2019
@jcklie
#1194 - Predict annotations directly instead of using PredictedSpan
e159f60 
- Fix tests
jcklie added a commit that referenced this issue Jun 5, 2019
@jcklie
#1194 - Predict annotations directly instead of using PredictedSpan
6290224 
- Add constant for isPrediction feature name
jcklie added a commit that referenced this issue Jun 6, 2019
@jcklie
Merge pull request #1206 from inception-project/feature/1194-directly…
17f05cb 
…-predict-annotation-type

#1194 - Directly predict annotation type
@reckart reckart closed this as completed Jun 6, 2019
reckart added a commit that referenced this issue Jun 6, 2019
@reckart
Merge branch 'master' into 0.10.x-uimav3
e7f4826 
* master: (60 commits)
  #1194 - Predict annotations directly instead of using PredictedSpan
  #867 - Group search results by feature value
  #867 - Group search results by feature value
  #867 - Group search results by feature value
  #1227 - Integrate and clean up PDFExtract code
  #867 - Group search results by feature value
  #867 - Group search results by feature value
  #867 - Group search results by feature value
  #867 - Group search results by feature value
  #1194 - Predict annotations directly instead of using PredictedSpan
  #1215  Write recommender evaluation scores to event log
  #1227 - Integrate and clean up PDFExtract code
  #1227 - Integrate and clean up PDFExtract code
  #1227 - Integrate and clean up PDFExtract code
  #987 - Use ElasticSearch Java Client API (via #1221)
  #1215 Write recommender evaluation scores to event log
  #804 easy way to resume annotation
  #804 - Easy way to resume annotation
  #1132 Unify training data
  #1132 Unify training data
  ...

% Conflicts:
%	inception-app-webapp/pom.xml
%	inception-concept-linking/src/main/java/de/tudarmstadt/ukp/inception/conceptlinking/recommender/NamedEntityLinker.java
%	inception-example-imls-data-majority/pom.xml
%	inception-imls-external/src/test/java/de/tudarmstadt/ukp/inception/recommendation/imls/external/ExternalRecommenderIntegrationTest.java
%	inception-recommendation/src/test/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImplIntegrationTest.java
This was referenced Jun 14, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcklie jcklie

Labels
Module: Recommender ⚙️ Refactoring
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
2 participants
@jcklie @reckart