New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search result list jumps back to top #1606
Comments
@reckart I'm sure the results list jumps because the sidebar is refreshed when a new document is loaded. I have two ideas to solve this: add some javascript because in js we can to my knowledge change the scrollbar position, I would save it when the result is clicked and then restore the position. |
You wanted to implement the tab for the new "curation" sidebar panel such that it shows only if the user has curator permissions. Would showing/hiding that tab still work if the sidebar is no longer refreshed? Since curation is a project-level permission and we switch between documents within a project... I guess it would? What about if documents are switched e.g. in active learning mode? Does that somehow rely on the sidebar refreshing behavior we have right now? I think it makes sense to not refresh the sidebar on switching documents, but maybe some sidebar panels need it and then they might have to "listen" to a relevant event and refresh themselves. |
- Fixes jumping to the top when (un)selecting a checkbox in the results list after scrolling down - when clicking on a result triggers a switch of the document, it still jumps - Only show group-level checkbox if there are any editable results in the group - Ignore non-editable results in a group when determining the group-level checkbox state
…sult-list-jumps-back-to-top #1606 - Search result list jumps back to top
…ons-on-closed-document * main: #1606 - Search result list jumps back to top
This has been fixed for the case of clicking on a checkbox in the lower parts of the search results. However, when clicking on a result causes a switch to another document, this causes the whole page to re-render and in this case the sidebar still jumps. |
Describe the bug
The search results list jumps back to the top when multiple documents are displayed in the list and one clicks on a result at the bottom.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The result list should stop at the place where the user scrolled to.
Screenshots
If applicable, add screenshots to help explain your problem.
Please complete the following information:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: